All maps point to the default location in flutter_map #3266

teolemon · 2022-11-04T18:37:44Z

All maps point to the default location in flutter_map (https://github.com/fleaflet/flutter_map/blob/fb3f27066be4900f291adaef39fcf665c9c0090d/lib/flutter_map.dart#L324)
As a result, all maps point to Kiev, leading users to believe we've been hacked
In truth, that's probably just us having a ! in our call to flutter_map (

smooth-app/packages/smooth_app/lib/knowledge_panel/knowledge_panels/knowledge_panel_world_map_card.dart

Line 28 in 0c00ad9

mapElement.pointers.first.geo!.lat,

) as spotted by @CQ94

teolemon added 🐛 bug Something isn't working 📖 Knowledge panels 🎯 P0 labels Nov 4, 2022

teolemon added this to 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 4, 2022

teolemon moved this to To discuss and validate in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 4, 2022

monsieurtanuki self-assigned this Nov 5, 2022

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 5, 2022

fix: openfoodfacts#3266

3d74aef

monsieurtanuki mentioned this issue Nov 5, 2022

fix: #3266 - centered world map #3268

Merged

teolemon added the 🗺️ Map widget label Nov 5, 2022

monsieurtanuki closed this as completed in #3268 Nov 5, 2022

monsieurtanuki added a commit that referenced this issue Nov 5, 2022

fix: #3266 - centered world map (#3268)

12a47b7

Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 5, 2022

github-actions bot mentioned this issue Nov 5, 2022

chore(develop): release 4.0.0 #3159

Merged

Provide feedback