Truncated button text

[monsieurtanuki]

What

In edit_new_packagings.dart, we display a button via addPanelButton, that truncates the text.
The expected text is
"add_packaging_photo_button_label": "Prenez des photos de toute information sur l'emballage/le recyclage",
In that particular case, the screen is small and the text is long.

[dipinsonwani]

Can I take this Issue?

[monsieurtanuki]

@dipinsonwani Sure! Before any code, what do you plan to do? Bigger/different button, text displayed smaller?

[dipinsonwani]

Make the text smaller according to the screen

[monsieurtanuki]

@dipinsonwani Please share screenshots before pushing the PR.

[dipinsonwani]

On Fri, Aug 4, 2023 at 2:19 PM monsieurtanuki ***@***.***> wrote: @dipinsonwani <https://github.com/dipinsonwani> Please share screenshots before pushing the PR. — Reply to this email directly, view it on GitHub <#4240 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANK2J4MCQNXLLWAD2TKPOFDXTSZQJANCNFSM6AAAAAAZVXGQBM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Sure

[M123-dev]

Any progress @dipinsonwani

[malik-vishu]

@monsieurtanuki Can you assign this issue to me?

[monsieurtanuki]

@malik-vishu Please share screenshots before pushing the PR.

[malik-vishu]

@monsieurtanuki Thank You for assigning...

[malik-vishu]

@monsieurtanuki I am unable to find this screen on app. How do I get this screen on app?

[monsieurtanuki]

@malik-vishu Go to a product page, then click on the edit button, and go to the edit package item - I think there are 2 of them and I'm not sure which one it is: try both.

[malik-vishu]

@monsieurtanuki When I click Edit Product this comes

Now which?
And sign in is compulsory?

[monsieurtanuki]

@malik-vishu As I told you it's packaging related - probably "packaging components".
And yes, in order to edit data you're supposed to be l

[monsieurtanuki]

Oops...
...you're supposed to be logged in.
Which shouldn't be a big problem anyway as you can test before actually modifying data.

[malik-vishu]

@monsieurtanuki I don't see the problem

[monsieurtanuki]

@monsieurtanuki I don't see the problem !

@malik-vishu Indeed there's no problem.
Unless you have a smaller screen and use a language where the translated string is longer.

[malik-vishu]

@monsieurtanuki Oh ok I'll check get back to you.

[malik-vishu]

@monsieurtanuki So this is on Pixel 2 emulator using French.

Before

[malik-vishu]

@monsieurtanuki

Is it all right?

Before - Pixel 2

After - Pixel 2

---

Before - Pixel 6

After - Pixel 6

[monsieurtanuki]

@malik-vishu Looks rather good!
My 2 cents:

• please learn to display "tables" in md, it's much more effective to check the before/after difference if you have 2 screenshots side by side
• could you test with a text artificially bigger, like 20 more characters?

[malik-vishu]

@monsieurtanuki Definitely I was thinking the same😅.
I'll test and get back to you.

[malik-vishu]

@monsieurtanuki
Added extra characters.

[monsieurtanuki]

@malik-vishu Cool! You're ready for a PR I guess! In a specific branch, please.

[malik-vishu]

@monsieurtanuki Yes I have created a branch.
Could you please add a Hacktoberfest label to this issue?

[teolemon]

@malik-vishu the whole repository has a Hacktoberfest label, and this issue has good first issue, so it is eligible already :-)

Pull requests can be made in any [GitHub](https://github.com/topics/hacktoberfest) or [GitLab](https://go.gitlab.com/ubCLKL) hosted project that’s participating in Hacktoberfest (look for the “hacktoberfest” topic)

[malik-vishu]

@monsieurtanuki Ok, Thank You
I will PR tomorrow. Till then check it - https://github.com/malik-vishu/smooth-app-hacktoberfest2023/tree/Button-text-formatting

[monsieurtanuki]

@malik-vishu Life is short. I'll review your PR in smooth-app when it's available.