Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5318 - added a "price privacy warning" dialog #5343

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added a "price privacy warning" dialog.
  • This dialog is displayed the first time the user tries to add a price.
  • This dialog is also displayed when the user taps on the app bar "info" button.

Screenshots

As "first time" As "info" button
Screenshot_1717772402 Screenshot_1717772375

Fixes bug(s)

Impacted files

  • app_en.arb: added 2 labels for the "price privacy warning" dialog
  • background_task_add_price.dart: now using new off-dart methods
  • knowledge_panel_action_card.dart: minor off-dart impact
  • price_model.dart: refactored
  • product_price_add_page.dart: added the "price privacy warning" dialog the very first time and in an app bar button
  • product_price_item.dart: now using new off-dart method
  • product_prices_page.dart: now using new off-dart method
  • pubspec.lock: wtf
  • pubspec.yaml: upgraded of openfoodfacts to 3.11.0
  • user_preferences.dart: added flag for "price privacy warning"
  • user_preferences_account.dart: now using new off-dart method

Impacted files:
* `app_en.arb`: added 2 labels for the "price privacy warning" dialog
* `background_task_add_price.dart`: now using new off-dart methods
* `knowledge_panel_action_card.dart`: minor off-dart impact
* `price_model.dart`: refactored
* `product_price_add_page.dart`: added the "price privacy warning" dialog the very first time and in an app bar button
* `product_price_item.dart`: now using new off-dart method
* `product_prices_page.dart`: now using new off-dart method
* `pubspec.lock`: wtf
* `pubspec.yaml`: upgraded of `openfoodfacts` to `3.11.0`
* `user_preferences.dart`: added flag for "price privacy warning"
* `user_preferences_account.dart`: now using new off-dart method
@monsieurtanuki
Copy link
Contributor Author

We're in trouble:
image

Any recent change in github's flutter version?

@teolemon
Copy link
Member

teolemon commented Jun 7, 2024

Can we add a link to change your pseudonym ? https://world.openfoodfacts.org/cgi/user.pl?type=edit&userid=teolemon

@monsieurtanuki
Copy link
Contributor Author

Can we add a link to change your pseudonym ? https://world.openfoodfacts.org/cgi/user.pl?type=edit&userid=teolemon

@teolemon That wouldn't be cool - UX-wise. Still the old "how can I land on the website and perform and action like edit or delete" issue.
image

@teolemon
Copy link
Member

teolemon commented Jun 7, 2024

ok, I've opened an issue for native support at a later point @monsieurtanuki

@monsieurtanuki
Copy link
Contributor Author

ok, I've opened an issue for native support at a later point @monsieurtanuki

Probably related to the new cookie feature.

@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Unfortunately can't merge, as evoked in #5343 (comment)

@teolemon teolemon mentioned this pull request Jun 8, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Project coverage is 7.57%. Comparing base (4d9c7fc) to head (7aff49b).
Report is 169 commits behind head on develop.

Files Patch % Lines
...h_app/lib/pages/prices/product_price_add_page.dart 0.00% 26 Missing ⚠️
...kages/smooth_app/lib/pages/prices/price_model.dart 0.00% 18 Missing ⚠️
...mooth_app/lib/pages/prices/product_price_item.dart 0.00% 5 Missing ⚠️
...ib/pages/preferences/user_preferences_account.dart 0.00% 4 Missing ⚠️
...ooth_app/lib/pages/prices/product_prices_page.dart 0.00% 4 Missing ⚠️
..._app/lib/background/background_task_add_price.dart 0.00% 2 Missing ⚠️
.../knowledge_panels/knowledge_panel_action_card.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5343      +/-   ##
==========================================
- Coverage     9.54%   7.57%   -1.98%     
==========================================
  Files          325     373      +48     
  Lines        16411   18882    +2471     
==========================================
- Hits          1567    1430     -137     
- Misses       14844   17452    +2608     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monsieurtanuki monsieurtanuki merged commit e94d61f into openfoodfacts:develop Jun 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add a one time privacy warning on price addition
3 participants