-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5318 - added a "price privacy warning" dialog #5343
feat: 5318 - added a "price privacy warning" dialog #5343
Conversation
Impacted files: * `app_en.arb`: added 2 labels for the "price privacy warning" dialog * `background_task_add_price.dart`: now using new off-dart methods * `knowledge_panel_action_card.dart`: minor off-dart impact * `price_model.dart`: refactored * `product_price_add_page.dart`: added the "price privacy warning" dialog the very first time and in an app bar button * `product_price_item.dart`: now using new off-dart method * `product_prices_page.dart`: now using new off-dart method * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded of `openfoodfacts` to `3.11.0` * `user_preferences.dart`: added flag for "price privacy warning" * `user_preferences_account.dart`: now using new off-dart method
Can we add a link to change your pseudonym ? https://world.openfoodfacts.org/cgi/user.pl?type=edit&userid=teolemon |
@teolemon That wouldn't be cool - UX-wise. Still the old "how can I land on the website and perform and action like |
ok, I've opened an issue for native support at a later point @monsieurtanuki |
Probably related to the new |
Thank you @teolemon for your review! Unfortunately can't merge, as evoked in #5343 (comment) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5343 +/- ##
==========================================
- Coverage 9.54% 7.57% -1.98%
==========================================
Files 325 373 +48
Lines 16411 18882 +2471
==========================================
- Hits 1567 1430 -137
- Misses 14844 17452 +2608 ☔ View full report in Codecov by Sentry. |
What
Screenshots
Fixes bug(s)
Impacted files
app_en.arb
: added 2 labels for the "price privacy warning" dialogbackground_task_add_price.dart
: now using new off-dart methodsknowledge_panel_action_card.dart
: minor off-dart impactprice_model.dart
: refactoredproduct_price_add_page.dart
: added the "price privacy warning" dialog the very first time and in an app bar buttonproduct_price_item.dart
: now using new off-dart methodproduct_prices_page.dart
: now using new off-dart methodpubspec.lock
: wtfpubspec.yaml
: upgraded ofopenfoodfacts
to3.11.0
user_preferences.dart
: added flag for "price privacy warning"user_preferences_account.dart
: now using new off-dart method