Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New UI for history/search lists #6161

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 9, 2025

Hi everyone!

The design from the POC is partially implemented in this PR.
Video: https://github.com/user-attachments/assets/8ad8d33d-042b-477e-85df-41b72d987045

Note: for performance reasons, the blur effect on pictures is disabled.

Items

  • The compatibility score is displayed
  • Nutri-score/Green Score are aligned horizontally
    IMG_1739

Loading items

Similar to the "normal" one
IMG_1738

OxF support

OxF products won't have a score and there's an icon in the bottom right corner
IMG_1741

Expandable FAB

On scroll, the FAB will be minimized
Untitled

Selection mode

The color of the AppBar is changed

Untitled

Popup Menu -> Modal sheet

Instead of the native popup (really ugly on iOS), a modal sheet is displayed:
IMG_1740

Nutri-score

The Nutri-score doesn't have a border and it looks weird without.
I force a border around the icon:

Untitled

@github-actions github-actions bot added 🥫 Product page 🌐 l10n ranking 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… asset cache cached assets (SVG…) for the knowledge panels User lists Assets cache labels Jan 9, 2025
@g123k g123k linked an issue Jan 9, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.07527% with 276 lines in your changes missing coverage. Please review.

Project coverage is 6.33%. Comparing base (4d9c7fc) to head (5f0fedd).
Report is 628 commits behind head on develop.

Files with missing lines Patch % Lines
...cards/product_cards/smooth_product_card_found.dart 3.33% 87 Missing ⚠️
...p/lib/pages/product/common/product_query_page.dart 0.00% 61 Missing ⚠️
...ds/product_cards/smooth_product_card_template.dart 0.00% 40 Missing ⚠️
...gets/smooth_expandable_floating_action_button.dart 0.00% 25 Missing ⚠️
...ges/smooth_app/lib/widgets/smooth_menu_button.dart 0.00% 25 Missing ⚠️
...pp/lib/pages/product/common/product_list_page.dart 0.00% 15 Missing ⚠️
...app/lib/generic_lib/widgets/picture_not_found.dart 0.00% 7 Missing ⚠️
.../lib/cards/product_cards/smooth_product_image.dart 0.00% 4 Missing ⚠️
..._app/lib/helpers/product_compatibility_helper.dart 0.00% 4 Missing ⚠️
...pages/product/common/product_list_item_simple.dart 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6161      +/-   ##
==========================================
- Coverage     9.54%   6.33%   -3.22%     
==========================================
  Files          325     451     +126     
  Lines        16411   25959    +9548     
==========================================
+ Hits          1567    1644      +77     
- Misses       14844   24315    +9471     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the milk carton sad ? It's not like we failed at downloading the image yet ?
Otherwise really cool.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the milk carton sad ? It's not like we failed at downloading the image yet ?
Otherwise really cool.

@teolemon teolemon merged commit 019e319 into openfoodfacts:develop Jan 9, 2025
6 checks passed
@g123k g123k deleted the search_ui branch January 28, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset cache cached assets (SVG…) for the knowledge panels Assets cache goldens 🌐 l10n 🥫 Product page ranking 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… User lists
Development

Successfully merging this pull request may close these issues.

New nutriscore/greenscore logo: wrong size / padding
3 participants