Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch to barcode scanner when clicking on the empty history screen #1363

Closed
wants to merge 4 commits into from
Closed

Conversation

bhattabhi013
Copy link
Contributor

What

Switch to barcode scanner when clicking on the empty history screen

Screenshot

navigateToScan.mp4

Fixes bug(s)

Part of

@bhattabhi013 bhattabhi013 requested a review from a team as a code owner March 28, 2022 12:01
@bhattabhi013
Copy link
Contributor Author

Hi @M123-dev ,
I've fixed this by navigating to the scan page with the click of search icon. Is there any need to handle the bottom tab navigation too?

@teolemon teolemon added history 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… labels Mar 28, 2022
@M123-dev
Copy link
Member

Heyyy @bhattabhi013 this doesn't quite fix the problem. It just pushes the scanner on top of the history. You are right we should instead switch the tab. This is probably going to be easier after #1313

@bhattabhi013
Copy link
Contributor Author

Sure @M123-dev ,
I think we should wait for #1313 to get resolved before proceeding with this.

@M123-dev M123-dev marked this pull request as draft March 28, 2022 19:20
@teolemon teolemon added this to the V1 milestone Apr 2, 2022
@teolemon
Copy link
Member

Is there a way to do that without the Navigator 2.0 migration ?

@g123k
Copy link
Collaborator

g123k commented May 18, 2022

Is there a way to do that without the Navigator 2.0 migration ?

Yes, totally. We just have to notify TabNavigator, to change the current tabItem

@teolemon
Copy link
Member

@bhattabhi013 could you try with this approach ?

@bhattabhi013
Copy link
Contributor Author

Sure @teolemon,
I'll work on it. Thanks @g123k for the suggestion.

@g123k
Copy link
Collaborator

g123k commented Jun 8, 2022

Hi @bhattabhi013,

Do you still have time to implement this, or should we allow someone else to work on it?

@bhattabhi013
Copy link
Contributor Author

Hi @g123k,
Yes sure, please assign someone else for this issue.

@bhattabhi013 bhattabhi013 removed their assignment Jun 8, 2022
@M123-dev M123-dev closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
history 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎯 P1 PR: needs rebase
Development

Successfully merging this pull request may close these issues.

Switch to barcode scanner when clicking on empty history screen or empty lists
4 participants