-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to change the camera mode without restarting #3008
feat: Allow to change the camera mode without restarting #3008
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3008 +/- ##
=======================================
Coverage 6.51% 6.51%
=======================================
Files 244 244
Lines 12026 12025 -1
=======================================
Hits 784 784
+ Misses 11242 11241 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code as such looks good @g123k but why is one of the light goldens now dark
Mmm you're right. The command is |
Yes the command is right, I just had a look at
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving as this isn't problem with the code just a thing we have to change in the tests, please fix that besides that everything looks good 👍🏼
What
An improvement for #2741