Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tagline always showing deprecated warning #3091

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

M123-dev
Copy link
Member

@M123-dev M123-dev commented Oct 4, 2022

What

The tagline was always showing the deprecated warning due to line 217 in smooth_product_carousel.

While searching for the problem I made the FutureBuilder more readable

@M123-dev M123-dev requested a review from a team as a code owner October 4, 2022 07:51
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, also experienced this 👍

@M123-dev M123-dev merged commit b8e1f82 into develop Oct 4, 2022
@M123-dev M123-dev deleted the fix-Tagline-always-showing-deprecated-warning branch October 4, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants