feat: 2427 - added "unselect image" button #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `background_task_unselect.dart`: Background task about unselecting a product image. * `edit_image_button.dart`: Standard text button for the "edit image" pages. Used to be in `NewCropPage` as `_OutlinedButton`. Impacted files: * `abstract_background_task.dart`: added new "unselect" task * `app_en.arb`: added a label for the "unselect image" button * `background_task_manager.dart`: unrelated minor fix * `new_crop_page.dart`: moved `_OutlinedButton` code to new file `edit_image_button.dart` * `offline_tasks_page.dart`: moved code to `OperationType` * `operation_type.dart`: new `enum` for "unselect"; new method `getLabel` * `product_image_viewer.dart`: changed the layout in order to add the "unselect image" button * `up_to_date_changes.dart`: included the new "unselect" type to product changes
|
@teolemon Thank you for your review! |
|
Sound ok. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files:
background_task_unselect.dart: Background task about unselecting a product image.edit_image_button.dart: Standard text button for the "edit image" pages. Used to be inNewCropPageas_OutlinedButton.Impacted files:
abstract_background_task.dart: added new "unselect" taskapp_en.arb: added a label for the "unselect image" buttonbackground_task_manager.dart: unrelated minor fixnew_crop_page.dart: moved_OutlinedButtoncode to new fileedit_image_button.dartoffline_tasks_page.dart: moved code toOperationTypeoperation_type.dart: newenumfor "unselect"; new methodgetLabelproduct_image_viewer.dart: changed the layout in order to add the "unselect image" buttonup_to_date_changes.dart: included the new "unselect" type to product changesWhat
Screenshot
Fixes bug(s)
Part of