fix: 2987 - The section header are smaller and not as color flashy as the titles of the individual settings. #3696

Adiii1436 · 2023-02-11T17:25:31Z

Fixed #2987
Increased header font size and provided bold white color.

…o develop

… titles of the individual settings.

AshAman999

Also can you attach a screnshot , how this affects the current UI

packages/smooth_app/lib/pages/preferences/user_preferences_settings.dart

Adiii1436 · 2023-02-12T17:26:43Z

It will look like this:

And as you said I have made changes to userPreferencesTitle and removed the repeated code.

Adiii1436 · 2023-02-16T17:07:15Z

@M123-dev @teolemon I have made changes as asked by @AshAman999 . Please review the changes.

M123-dev · 2023-02-16T17:26:04Z

packages/smooth_app/lib/pages/preferences/user_preferences_widgets.dart

-          style: Theme.of(context).textTheme.displaySmall?.copyWith(
-                height: 2.5,
-              ),
+          style: const TextStyle(fontSize: 24, fontWeight: FontWeight.bold),


Thanks a lot @Adiii1436

Could you keep the

Theme.of(context).textTheme.displaySmall?.copyWith(

and do your changed in this copyWith.

This just means that you use the global text style and just change parts of it.
Say we plan to change the text font, we can just change it in the global theme and not at every text in the app

Thankyou @M123-dev for guiding me. I will make changes right away.

@M123-dev I have made changes as you said.

codecov-commenter · 2023-02-20T14:15:56Z

Codecov Report

Merging #3696 (5643793) into develop (939b0d9) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3696   +/-   ##
========================================
  Coverage    10.97%   10.97%           
========================================
  Files          265      265           
  Lines        13071    13071           
========================================
  Hits          1435     1435           
  Misses       11636    11636

Impacted Files	Coverage Δ
...ib/pages/preferences/user_preferences_widgets.dart	`12.90% <0.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

M123-dev · 2023-02-21T16:14:57Z

packages/smooth_app/lib/pages/preferences/user_preferences_widgets.dart

+                  ? const Color(0xFF000000)
+                  : const Color(0xFFFFFFFF)),


Could you make it Colors.black and Colors.white, thats way easier to understand :D

Made the changes @M123-dev

M123-dev

Happy to test this out. Thanks @Adiii1436

My only concern is maybe with the coming AMOLED mode, that the fixed colors could be problematic

cc: @AshAman999 the PR is blocked on you 😄 what do you say

packages/smooth_app/lib/pages/preferences/user_preferences_widgets.dart

teolemon · 2023-05-18T16:37:44Z

packages/smooth_app/lib/pages/preferences/user_preferences_widgets.dart

@@ -235,8 +235,7 @@ class UserPreferencesTitle extends StatelessWidget {
        ),
        child: Text(
          label,
-          style: Theme.of(context).textTheme.displaySmall?.copyWith(
-                height: 2.5,
+          style: Theme.of(context).textTheme.displayLarge!


Suggested change

style: Theme.of(context).textTheme.displayLarge!

style: Theme.of(context).textTheme.displayLarge

teolemon · 2023-05-18T16:38:39Z

@AshAman999

AshAman999 · 2023-05-19T08:12:16Z

This is how it will look, same color scheme as discussed in yesterday meeting,

	Light	Dark	Amoled
Theme

ps: good to have Chat GPT help me write good markdowns real quick.

teolemon · 2023-05-19T16:27:20Z

perfect @AshAman999 , thanks 👌

AshAman999 · 2023-05-19T16:46:05Z

Thanks @Adiii1436 for your PR 😊

Adiii1436 added 3 commits February 10, 2023 21:37

changing font size of settings tab

229bcf2

Merge branch 'develop' of https://github.com/Adiii1436/smooth-app int…

1bbad10

…o develop

fixed : The section header are smaller and not as color flashy as the…

734480f

… titles of the individual settings.

Adiii1436 requested a review from a team as a code owner February 11, 2023 17:25

github-actions bot assigned Adiii1436 Feb 11, 2023

Adiii1436 changed the title ~~fix:The section header are smaller and not as color flashy as the titles of the individual settings.~~ fix: 2987 - The section header are smaller and not as color flashy as the titles of the individual settings. Feb 11, 2023

Adiii1436 mentioned this pull request Feb 12, 2023

Add a shortcut in app settings to In-app settings #3459

Closed

AshAman999 requested changes Feb 12, 2023

View reviewed changes

packages/smooth_app/lib/pages/preferences/user_preferences_settings.dart Outdated Show resolved Hide resolved

Added changes to user_preferences_widgets.dart

135dda2

github-actions bot added the Android label Feb 12, 2023

Adiii1436 requested a review from AshAman999 February 13, 2023 13:30

M123-dev reviewed Feb 16, 2023

View reviewed changes

Adiii1436 and others added 2 commits February 17, 2023 00:39

Merge branch 'openfoodfacts:develop' into issue##2987

e57bf73

made changes inside copyWith and made it dynamic according to brightness

503b9cb

Adiii1436 requested review from M123-dev and removed request for AshAman999 February 16, 2023 20:36

Adiii1436 added 3 commits February 18, 2023 00:09

Merge branch 'openfoodfacts:develop' into issue##2987

f8974f6

Merge branch 'openfoodfacts:develop' into issue##2987

59f17ff

Merge branch 'openfoodfacts:develop' into issue##2987

769d841

M123-dev reviewed Feb 21, 2023

View reviewed changes

Adiii1436 and others added 4 commits February 21, 2023 22:12

Merge branch 'openfoodfacts:develop' into issue##2987

b968f29

Merge branch 'openfoodfacts:develop' into issue##2987

d1e49e6

Merge branch 'openfoodfacts:develop' into issue##2987

f726612

Modified Header line in user_preferences_widgets.dart

e01ed27

Adiii1436 requested a review from M123-dev February 25, 2023 15:08

M123-dev approved these changes Feb 26, 2023

View reviewed changes

M123-dev requested a review from AshAman999 February 26, 2023 10:59

Merge branch 'openfoodfacts:develop' into issue##2987

a17f361

teolemon reviewed May 18, 2023

View reviewed changes

packages/smooth_app/lib/pages/preferences/user_preferences_widgets.dart Outdated Show resolved Hide resolved

Apply suggestions from code review

a9910d7

teolemon reviewed May 18, 2023

View reviewed changes

AshAman999 and others added 2 commits May 19, 2023 13:10

Merge branch 'develop' into issue##2987

13ec90e

use same color but larger text

5643793

AshAman999 requested a review from teolemon May 19, 2023 16:15

teolemon approved these changes May 19, 2023

View reviewed changes

teolemon merged commit b88c45f into openfoodfacts:develop May 19, 2023

github-actions bot mentioned this pull request May 19, 2023

chore(develop): release 4.8.0 #3937

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 2987 - The section header are smaller and not as color flashy as the titles of the individual settings. #3696

fix: 2987 - The section header are smaller and not as color flashy as the titles of the individual settings. #3696

Adiii1436 commented Feb 11, 2023 •

edited

Loading

AshAman999 left a comment

Adiii1436 commented Feb 12, 2023

Adiii1436 commented Feb 16, 2023

M123-dev Feb 16, 2023 •

edited

Loading

Adiii1436 Feb 16, 2023 •

edited

Loading

Adiii1436 Feb 16, 2023

codecov-commenter commented Feb 20, 2023 •

edited

Loading

M123-dev Feb 21, 2023

Adiii1436 Feb 23, 2023

Adiii1436 Feb 25, 2023

M123-dev left a comment •

edited

Loading

teolemon May 18, 2023

teolemon commented May 18, 2023

AshAman999 commented May 19, 2023

teolemon commented May 19, 2023

AshAman999 commented May 19, 2023

	style: Theme.of(context).textTheme.displayLarge!
	style: Theme.of(context).textTheme.displayLarge

fix: 2987 - The section header are smaller and not as color flashy as the titles of the individual settings. #3696

fix: 2987 - The section header are smaller and not as color flashy as the titles of the individual settings. #3696

Conversation

Adiii1436 commented Feb 11, 2023 • edited Loading

AshAman999 left a comment

Choose a reason for hiding this comment

Adiii1436 commented Feb 12, 2023

Adiii1436 commented Feb 16, 2023

M123-dev Feb 16, 2023 • edited Loading

Choose a reason for hiding this comment

Adiii1436 Feb 16, 2023 • edited Loading

Choose a reason for hiding this comment

Adiii1436 Feb 16, 2023

Choose a reason for hiding this comment

codecov-commenter commented Feb 20, 2023 • edited Loading

Codecov Report

M123-dev Feb 21, 2023

Choose a reason for hiding this comment

Adiii1436 Feb 23, 2023

Choose a reason for hiding this comment

Adiii1436 Feb 25, 2023

Choose a reason for hiding this comment

M123-dev left a comment • edited Loading

Choose a reason for hiding this comment

teolemon May 18, 2023

Choose a reason for hiding this comment

teolemon commented May 18, 2023

AshAman999 commented May 19, 2023

teolemon commented May 19, 2023

AshAman999 commented May 19, 2023

Adiii1436 commented Feb 11, 2023 •

edited

Loading

M123-dev Feb 16, 2023 •

edited

Loading

Adiii1436 Feb 16, 2023 •

edited

Loading

codecov-commenter commented Feb 20, 2023 •

edited

Loading

M123-dev left a comment •

edited

Loading