fix: 3459 - Added a shortcut in app settings to In-app settings #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3718 +/- ##
==========================================
Coverage ? 10.41%
==========================================
Files ? 273
Lines ? 13809
Branches ? 0
==========================================
Hits ? 1438
Misses ? 12371
Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
reviewed
Feb 21, 2023
There was a problem hiding this comment.
Heyy @Adiii1436 looks good, but could you add the strings to the localization file + I added some suggestions for the strings itself
| Expanded( | ||
| child: ListTile( | ||
| title: Text( | ||
| 'Advanced App Settings', |
There was a problem hiding this comment.
Could you add this String to lib/l10n/app_en.arb
There was a problem hiding this comment.
Yes I will add it. And modify the strings
| subtitle: const Padding( | ||
| padding: EdgeInsets.only(top: SMALL_SPACE), | ||
| child: Text( | ||
| 'Open advanced app settings for Open Food Facts on your device', |
There was a problem hiding this comment.
Could you add this String to lib/l10n/app_en.arb
| Expanded( | ||
| child: ListTile( | ||
| title: Text( | ||
| 'Advanced App Settings', |
There was a problem hiding this comment.
Suggested change
| 'Advanced App Settings', | |
| 'Native App Settings', |
| subtitle: const Padding( | ||
| padding: EdgeInsets.only(top: SMALL_SPACE), | ||
| child: Text( | ||
| 'Open advanced app settings for Open Food Facts on your device', |
There was a problem hiding this comment.
Suggested change
| 'Open advanced app settings for Open Food Facts on your device', | |
| 'Open systems settings for Open Food Facts', |
Adiii1436
force-pushed
the
fixed#3459
branch
from
c79b959 to
e5bf964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3459
