Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bring the "Hot reload" feature back #4279

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 8, 2023

Hi everyone!

After the migration to GoRouter, the Hot Reload feature from Dart/Flutter didn't work anymore and was a real pain.
The problem was coming from the GoRouter object being recreated on every Hot Reload.

By using a singleton instead, we're now safe and the Hot Reload works again ☺️

@g123k g123k requested a review from a team as a code owner July 8, 2023 09:18
@codecov-commenter
Copy link

Codecov Report

Merging #4279 (02a5fb4) into develop (505c0d1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4279      +/-   ##
===========================================
- Coverage    10.87%   10.87%   -0.01%     
===========================================
  Files          285      285              
  Lines        14172    14175       +3     
===========================================
  Hits          1541     1541              
- Misses       12631    12634       +3     
Impacted Files Coverage Δ
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@g123k
Copy link
Collaborator Author

g123k commented Jul 13, 2023

Thanks for your review, let's merge this one!

@g123k g123k merged commit fa68745 into openfoodfacts:develop Jul 13, 2023
@g123k g123k deleted the hot_reload branch July 13, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants