Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prices feedback form missing a "SafeArea" zone #5448

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 27, 2024

Hi everyone,

That's my fault, I forgot to check on Android/iOS and the feedback form was below the navigation bar.

@g123k g123k requested a review from a team as a code owner June 27, 2024 07:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 7.18%. Comparing base (4d9c7fc) to head (049c78d).
Report is 230 commits behind head on develop.

Files Patch % Lines
...kages/smooth_app/lib/pages/prices/prices_page.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5448      +/-   ##
==========================================
- Coverage     9.54%   7.18%   -2.37%     
==========================================
  Files          325     391      +66     
  Lines        16411   20384    +3973     
==========================================
- Hits          1567    1464     -103     
- Misses       14844   18920    +4076     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k g123k changed the title fix: Prices feedback form missing "SafeArea" zone fix: Prices feedback form missing a "SafeArea" zone Jun 27, 2024
@teolemon teolemon merged commit 08a8df1 into openfoodfacts:develop Jun 28, 2024
7 checks passed
@g123k g123k deleted the feedback_form_safearea branch December 30, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants