feat: add error logs to parser #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not adding to tags_ids if it's already in it by another normalized synonym
Remove end-line comma
Used black
alexgarel
approved these changes
Aug 19, 2022
| correctly_written.match(property_name) | ||
| and correctly_written.match(lc) | ||
| ): | ||
| raise Exception |
There was a problem hiding this comment.
You have to instanciate the Exception when you throw it.
It's not a good pattern to use an Exception an empty expect, because you may hide some other exception. Here you just have to use the if / then / else
There was a problem hiding this comment.
I see it's to unify handling of the ValueError in split, but I still think it's not a good idea ;-)
|
@BryanH01 thinking how we will use the parser, I think a good addition to your job, would be to collect errors instead of simply log them and add them in the neo4j database in a special parsing_errors entry. |
|
⬆️ made it an issue : #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What