Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFC Orders] DFC Import of products #12139

Closed
mkllnk opened this issue Feb 9, 2024 · 4 comments · Fixed by #12274
Closed

[DFC Orders] DFC Import of products #12139

mkllnk opened this issue Feb 9, 2024 · 4 comments · Fixed by #12274
Assignees

Comments

@mkllnk
Copy link
Member

mkllnk commented Feb 9, 2024

Funded Feature. Please track ALL ASSOCIATED WORK under the associated tracking code: #11678 DFC Orders

Description

Get product list from DFC producer store and let the user decide which ones to import.

  • Confirm valid OIDC tokens are present or refresh. See [DFC Orders] Upgrade DFC authentication flow #11947.
  • Catalog URL is hardcoded in the first iteration. (ask @RaggedStaff)
  • The producer catalog is fetched from the DFC URI.
  • List of products is displayed on the screen.
  • Each product has an import button to import that product into OFN. Technically, the form can contain the whole JSON and post it do the OFN DFC API to do the work.
  • Already imported products have a disabled import button.
  • The import stores the @id attribute of the product on the other platform to record the link and remember that it was imported. See [DFC Orders] Link Products on external platforms #11946.
@RaggedStaff
Copy link
Collaborator

@mkllnk mkllnk moved this from Backlog to In progress in DFC Orders Implementation Phase 1 Feb 19, 2024
@mkllnk mkllnk self-assigned this Feb 19, 2024
@mkllnk
Copy link
Member Author

mkllnk commented Mar 15, 2024

@RaggedStaff, will the product catalog include all information in one graph or do we have to query more?

The OFN catalog_items endpoint has everything included because that's what the DFC Prototype needed. I don't have functionality to resolve resources yet and time is precious.

Also, can the first iteration just import all products and then the OFN shop decides which ones they want to display in the shop? Much easier then implementing the UX to list and import products one by one.

@sigmundpetersen sigmundpetersen moved this from All the things to In Dev 💪 in OFN Delivery board Mar 15, 2024
@RaggedStaff
Copy link
Collaborator

@mkllnk That's fine for 1st iteration.

Just a small clarifying question: are we importing all the products against each hub? Is there a way to only import a Producers products once & for each hub to link to them? I'm thinking that sounds hard but curious how hard? 🤨

@mkllnk
Copy link
Member Author

mkllnk commented Mar 18, 2024

are we importing all the products against each hub?

Yes, at the moment we do.

Is there a way to only import a Producers products once & for each hub to link to them?

Yes, that would be quite easy. We just need to check if we have the semantic id stored already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants