Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFC Orders] List products to import on screen #12301

Open
7 of 11 tasks
mkllnk opened this issue Mar 22, 2024 · 1 comment
Open
7 of 11 tasks

[DFC Orders] List products to import on screen #12301

mkllnk opened this issue Mar 22, 2024 · 1 comment
Assignees

Comments

@mkllnk
Copy link
Member

mkllnk commented Mar 22, 2024

ℹ️ Funded Feature. Please track ALL ASSOCIATED WORK under the associated tracking code #11678 DFC Orders

A basic product import has been done:

But there are some outstanding tasks from #12139:

  • The input field "Enterprise" should be labelled "Create products for enterprise:".
  • List of products to import is displayed on the screen.
  • Each product has an import button to import that product into OFN. Technically, the form can contain the whole JSON and post it do the OFN DFC API to do the work. But another controller action or reflex can do this as well.
  • Already imported products have a disabled import button.

Import improvements

@drummer83 found several issues during the import. When importing as variant of existing products:

  • Imported variants of unit type 'item' have variant name = original name + (unit + unit scale). That's okay.
  • Imported variants of other unit type have variant name = original name
  • Imported variants have no SKU (probably ok). The SKU needs to be unique. It was probably in conflict in this case.
  • Imported variants of unit type 'item' have unit '1piece' now.
  • Imported variants have price 0.
  • Imported variants have stock 0. This is probably good. We don't want to duplicate the stock across platforms.
  • Imported variants have tax category 'default' - no matter the original tax category. Tax categories are not modelled in OFN.

Importing as new products (from a different enterprise):

  • Imported variants of other unit type with original variant name = '' have variant name = product name '-' unit That's okay.
  • Imported variants have price 0.
  • Imported variants have stock 0. This is probably good. We don't want to duplicate the stock across platforms.
  • Imported variants have tax category 'default' - no matter the original tax category. Tax categories are not modelled in OFN.
@RaggedStaff
Copy link
Collaborator

Couple of enhancements/thoughts:

  1. Already imported products have an "Update" button.
  2. We need an option to import all
  3. I think a modal that allows checking of certain products might be more user-frienldy (as in check to include Product in chosen enterprise)...
  4. ... but that implies the option to remove the Product by unchecking the box.

I think this is additional scope, but I'd like to get an estimate, with these extra options (assuming the current 3 days doesn't stand), @mkllnk ?

@dacook dacook self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: All the things 💤
Development

No branches or pull requests

4 participants