-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Cable Ready responses from User related controllers #12997
base: master
Are you sure you want to change the base?
Conversation
d14143a
to
f6b05fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool!
We need some better testing instructions though. I'll edit them to let the testers know which functionality is affected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for splitting this into a smaller PR.
Just a couple of things to check out:
f6b05fb
to
009d8be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, ready to test!
What should we test? The flow for user registration, login, password reset, and confirmation should be retained.
I think this would be a regression, as the modal is relevant to inform the user that access to that page is not granted. Also, the modal should not appear a second time.
Summary Everything looks great, except the 401 scenario. I think this usability regression should be prevented. Would you be up to improive this @wandji20 ? Moving to in progress, for now. |
What? Why?
Closes #
This is the first part of moving away from Cable Ready in favor of Hotwire related to Replace mrujs with turbo #12794
Since Turbo covers everything cable_ready does, we can safely move from cable_ready and mrujs to turbo.
This PR covers changes to the User Session, Password, Registration, and Confirmation Controllers.
What should we test?
The flow for user registration, login, password reset, and confirmation should be retained.
Release notes
Changelog Category (reviewers may add a label for the release notes):
Dependencies
N/A
Documentation updates
N/A