Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the :selected option with the default tax category #12989 #13009

Merged
merged 6 commits into from
Jan 7, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions spec/helpers/spree/admin/tax_categories_helper_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# frozen_string_literal: true

require "spec_helper"

RSpec.describe Spree::Admin::TaxCategoriesHelper do
describe '#tax_category_dropdown_options' do
let!(:default_tax_category) { create(:tax_category, is_default: true) }
let!(:other_tax_category) { create(:tax_category, is_default: false) }

context 'when products require a tax category' do
it 'returns include_blank as false' do
options = helper.tax_category_dropdown_options(true)
expect(options[:include_blank]).to eq(false)
end

it 'returns the default tax category as selected' do
options = helper.tax_category_dropdown_options(true)
expect(options[:selected]).to eq(default_tax_category.id)
end

context 'when no default tax category exists' do
before { default_tax_category.update(is_default: false) }

it 'returns nil for the selected value' do
options = helper.tax_category_dropdown_options(true)
expect(options[:selected]).to be_nil
end
end
end

context 'when products do not require a tax category' do
it 'returns include_blank as the translated "none" string' do
options = helper.tax_category_dropdown_options(false)
expect(options[:include_blank]).to eq(I18n.t(:none))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to actually check the translation is working,ie:

Suggested change
expect(options[:include_blank]).to eq(I18n.t(:none))
expect(options[:include_blank]).to eq("None")

end

it 'does not include a selected tax category' do
options = helper.tax_category_dropdown_options(false)
expect(options[:selected]).to be_nil
end
end
end
end
Loading