-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the :selected option with the default tax category #12989 #13009
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7d5bb4a
Added the :selected option with the default tax category
MrBowmanXD d95bb77
Fixed the logic and moved the code to a helper file
MrBowmanXD 980f86c
Fixed the lint errors
MrBowmanXD 3199118
Removed the :selected attribute when the tax category is not required…
MrBowmanXD 5def2b5
Added a spec file in order to test the tax categories helper
MrBowmanXD 0d4904d
Small change in spec file
MrBowmanXD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# frozen_string_literal: true | ||
|
||
require "spec_helper" | ||
|
||
RSpec.describe Spree::Admin::TaxCategoriesHelper do | ||
describe '#tax_category_dropdown_options' do | ||
let!(:default_tax_category) { create(:tax_category, is_default: true) } | ||
let!(:other_tax_category) { create(:tax_category, is_default: false) } | ||
|
||
context 'when products require a tax category' do | ||
it 'returns include_blank as false' do | ||
options = helper.tax_category_dropdown_options(true) | ||
expect(options[:include_blank]).to eq(false) | ||
end | ||
|
||
it 'returns the default tax category as selected' do | ||
options = helper.tax_category_dropdown_options(true) | ||
expect(options[:selected]).to eq(default_tax_category.id) | ||
end | ||
|
||
context 'when no default tax category exists' do | ||
before { default_tax_category.update(is_default: false) } | ||
|
||
it 'returns nil for the selected value' do | ||
options = helper.tax_category_dropdown_options(true) | ||
expect(options[:selected]).to be_nil | ||
end | ||
end | ||
end | ||
|
||
context 'when products do not require a tax category' do | ||
it 'returns include_blank as the translated "none" string' do | ||
options = helper.tax_category_dropdown_options(false) | ||
expect(options[:include_blank]).to eq(I18n.t(:none)) | ||
end | ||
|
||
it 'does not include a selected tax category' do | ||
options = helper.tax_category_dropdown_options(false) | ||
expect(options[:selected]).to be_nil | ||
end | ||
end | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to actually check the translation is working,ie: