Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate stock from DFC wholesale variants #13049

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Dec 20, 2024

What? Why?

When importing DFC products, two products can be coupled as retail variant and wholesale variant of the same product. We aim to sell the retail variant through an OFN shop and then place backorders for the wholesale variant to make use of economies of scale.

We already calculated the price of a retail variant from its wholesale variant:

Now we also calculate the stock level from the wholesale variant.

What should we test?

  • Import a DFC catalog at Admin -> Product Import
  • Observe the product prices and stock levels.
  • Add retail products to an order cycle.
  • Change stock levels in Shopify.
  • Add a retail variant to your OFN cart.
  • The stock level should get updated correctly.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk added the user facing changes Thes pull requests affect the user experience label Dec 20, 2024
@mkllnk mkllnk self-assigned this Dec 20, 2024
@mkllnk mkllnk marked this pull request as ready for review December 20, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user facing changes Thes pull requests affect the user experience
Projects
Status: Code review 🔎
Development

Successfully merging this pull request may close these issues.

[DFC Orders] Compute stock of retail variants from wholesale variants
1 participant