Fix #380 (#387)

openforcefield · Oct 5, 2021 · 9a1b1b9 · 9a1b1b9
1 parent 0949a21
commit 9a1b1b9
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/docs/releasehistory.rst b/docs/releasehistory.rst
@@ -14,7 +14,8 @@ Releases follow the ``major.minor.micro`` scheme recommended by
 Bugfixes
 """"""""
 
-* PR `#375 <https://github.com/openforcefield/openff-evaluator/pull/375>`_: Fix import from collections.abc
+* PR `#375 <https://github.com/openforcefield/openff-evaluator/pull/375>`_: Fix #374 - import from collections.abc
+* PR `#387 <https://github.com/openforcefield/openff-evaluator/pull/387>`_: Fix #380 - Recursion error in local file storage
 
 New Features
 """"""""""""

diff --git a/openff/evaluator/storage/localfile.py b/openff/evaluator/storage/localfile.py
@@ -18,7 +18,7 @@ class LocalFileStorage(StorageBackend):
  @property
  def root_directory(self):
  """str: Returns the directory in which all stored objects are located."""
- return self.root_directory
+ return self._root_directory
 
  def __init__(self, root_directory="stored_data"):
 

diff --git a/openff/evaluator/tests/test_storage/test_local.py b/openff/evaluator/tests/test_storage/test_local.py
@@ -0,0 +1,15 @@
+"""
+Units tests for openff.evaluator.storage.localfile
+"""
+import os
+
+from openff.evaluator.storage import LocalFileStorage
+
+
+def test_root_directory(tmpdir):
+
+ local_storage_path = os.path.join(tmpdir, "stored-data")
+ local_storage = LocalFileStorage(root_directory=local_storage_path)
+
+ assert os.path.isdir(local_storage_path)
+ assert local_storage.root_directory == local_storage_path