Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #365 #367

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Fix #365 #367

merged 1 commit into from
Aug 25, 2021

Conversation

SimonBoothroyd
Copy link
Contributor

Description

Fixes #365. The following now successfully roundtrips:

x = ThermoMLDataSet.from_doi("10.1016/j.jct.2010.12.028")
y = PhysicalPropertyDataSet.from_pandas(x.to_pandas())

Status

  • Ready to go

@codecov
Copy link

codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #367 (645d724) into master (bc57e1d) will not change coverage.
The diff coverage is n/a.

@SimonBoothroyd SimonBoothroyd merged commit 976cf1e into master Aug 25, 2021
@SimonBoothroyd SimonBoothroyd deleted the fix-from-pandas-regex branch August 25, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to/from_pandas does not roundtrip
1 participant
@SimonBoothroyd