Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import from collections.abc #375

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

lilyminium
Copy link
Contributor

Description

Fixes #374

Status

  • Ready to go

@lilyminium lilyminium closed this Sep 27, 2021
@lilyminium lilyminium reopened this Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #375 (e48d2ce) into master (64d7440) will decrease coverage by 2.41%.
The diff coverage is 100.00%.

Copy link
Contributor

@SimonBoothroyd SimonBoothroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lilyminium - feel free to merge once the tests come back green!

@SimonBoothroyd
Copy link
Contributor

(I restarted the tests so the OE license should be available)

@lilyminium
Copy link
Contributor Author

@SimonBoothroyd thanks for that -- the Mac tests are still failing with no OpenEye, should they be re-run also?

@SimonBoothroyd SimonBoothroyd merged commit 28a799f into openforcefield:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing ABCs from collections is deprecated
2 participants