Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility for OpenMM 7 and 8 #495

Merged
merged 5 commits into from
Feb 10, 2023
Merged

Add compatibility for OpenMM 7 and 8 #495

merged 5 commits into from
Feb 10, 2023

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Feb 9, 2023 •
edited
Loading

Description

This PR adds support for both OpenMM 7 and 8.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Update _Simulation to include context attribute
  • Test on OpenMM 7
  • Test on OpenMM 8
  • Include support plans in release notes

Questions

  • Question1

Status

  • Ready to go

@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Merging #495 (27d66cd) into main (9154134) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review February 9, 2023 22:05
@mattwthompson mattwthompson merged commit 66adc50 into main Feb 10, 2023
@mattwthompson mattwthompson deleted the openmm-8 branch February 10, 2023 01:20
@mattwthompson mattwthompson mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattwthompson