Update tutorials #499
Merged
Update tutorials #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
There have been a number of module changes since the shipped JSON files were generated. I'm going to need to get the simulations up and running on a secondary machine to regenerate the data. |
mattwthompson
commented
Feb 14, 2023
| @@ -10,15 +10,15 @@ dependencies: | |||
| # Testing and development | |||
| - pytest | |||
| - pytest-cov | |||
| - codecov | |||
There was a problem hiding this comment.
There's no need to install the codecov package now that their action is used. nbval is used to run tutorials, which only run on half of the matrix but is light enough that there is no need to install it inside of a conditional
mattwthompson
commented
Feb 14, 2023
| - requests-mock # For testing http requests. | ||
| - smirnoff-plugins # For testing custom nonbonded forces | ||
| - coverage >=4.4 | ||
|
|
||
| # Standard dependencies | ||
| - openff-toolkit >=0.11.0 | ||
| - openmm =8 | ||
| - pymbar >=4 |
There was a problem hiding this comment.
The version here is enforced later in the workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This takes #485 and runs it with upstream permissions
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status