-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AmoebaMultipoleForce to disable_pbc #533
Conversation
Codecov Report
Additional details and impacted files |
@mattwthompson can you look at this whenever you have a chance? |
Co-authored-by: Matt Thompson <mattwthompson@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - it'd be nice to have a test, but the code it's changing was already missing coverage.
Could you add a one-liner to the release notes? (I think I forgot to add a section for 0.4.6 ... I'll clean that up later.)
@mattwthompson Amoeba got misspelled
It's hard to add a test without my changes to smirnoff_plugins also being added because noone else is using AmoebaMultipoleForce, I started running end-to-end tests before I left last night but just got in today. |
Description
Support AmoebaMultipoleForce in utils/openmm/disable_pbc
Todos
Notable points that this PR has either accomplished or will accomplish.
Status