Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions migration #12

Merged
merged 6 commits into from
May 26, 2020
Merged

GitHub Actions migration #12

merged 6 commits into from
May 26, 2020

Conversation

mattwthompson
Copy link
Member

I shamelessly copied the script @jaimergp wrote for the toolkit and trimmed it down to this

@mattwthompson
Copy link
Member Author

Strange, the pip install wasn't able to remove the conda install (openforcefields was installed as an openforcefield dependency), even though I'm pretty sure that's precisely how it worked with Travis

@mattwthompson
Copy link
Member Author

mattwthompson commented May 13, 2020

Badges for this PR: Build Status

Badge for master after this PR (should be broken now): Build Status

@mattwthompson
Copy link
Member Author

@jaimergp please look this over and see if I broke anything :)

@jaimergp
Copy link
Contributor

jaimergp commented May 25, 2020

Hi @mattwthompson, would you mind if we use this PR to try that GH Action that Daniel Smith suggested? I am adding that to MolSSI/cookiecutter-cms#95 as well, so it might be a nice "real word" check while we are at it, if you don't mind :) Shouldn't be much of a change:

  • We need to add the action, which would replace the env setup:
    - name: Setup Conda Environment
      uses: goanpeca/setup-miniconda@v1
      with:
         activate-environment: test
         environment-file: devtools/conda-envs/test_env.yaml
         auto-activate-base: false
  • Replace later shell: bash lines with shell: bash -l {0}

@jaimergp
Copy link
Contributor

Wow, that was... unexpectedly great!

@dotsdl
Copy link
Member

dotsdl commented May 26, 2020

LGTM! Great work y'all! it's a very clean implementation. 😁

@mattwthompson
Copy link
Member Author

Thanks @jaimergp @dotsdl

@mattwthompson mattwthompson merged commit a296df6 into master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants