Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for disulfides #15

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

Yoshanuikabundi
Copy link
Collaborator

@Yoshanuikabundi Yoshanuikabundi commented Jan 24, 2025

Closes #24

Changes made in this Pull Request:

  • Creates folder for keeping PDB generating scripts with their products
  • Adds two new cross-chain disulfide examples
  • Moves the existing cross-chain disulfide test to live in the new folder

Tests are failing because the cross-chain-disulfide-with-another-chain-between-the-crosslinked-chains behavior is broken. Tests are now failing because the existing behavior in Topology.from_pdb is incorrect.

@Yoshanuikabundi Yoshanuikabundi marked this pull request as ready for review January 30, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test of a PDB file with Disulfide bonds (described by CONECT record)
2 participants