Skip to content

Commit

Permalink
Fall back to useRandomCoords=True if RDKit conformer generation fai…
Browse files Browse the repository at this point in the history
…ls (#1346)

* Add test reproducing #822

* Fall back to `useRandomCoords=True` if first conformer generation fails

* Update openff/toolkit/tests/test_toolkits.py

Co-authored-by: Jeff Wagner <jwagnerjpl@gmail.com>

* Update release history

Co-authored-by: Jeff Wagner <jwagnerjpl@gmail.com>
  • Loading branch information
mattwthompson and j-wags authored Jul 29, 2022
1 parent cc6ccc4 commit 94a569a
Show file tree
Hide file tree
Showing 4 changed files with 427 additions and 3 deletions.
3 changes: 3 additions & 0 deletions docs/releasehistory.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ print(value_roundtrip)

### Behaviors changed and bugfixes

- [PR #1346](https://github.com/openforcefield/openff-toolkit/pull/1346): Conformer generation with RDKit
will use `useRandomCoords=True` on a second attempt if the first attempt fails, which sometimes
happens with large molecules.
- [PR #1277](https://github.com/openforcefield/openff-toolkit/pull/1277): Version 0.3 `<Electrostatics>`
sections of OFFXML files will automatically be up-converted (in memory) to version 0.4 according
to the recomendations provided in
Expand Down
Loading

0 comments on commit 94a569a

Please sign in to comment.