Skip to content

Commit

Permalink
Switch version handling to versioningit (#1968)
Browse files Browse the repository at this point in the history
* Switch version handling to `versioningit`

* Do not use shallow fetch

* Fix

* Fix

* Add `pip list`

* Debug docs builds

* Cleanup/simplify diff
  • Loading branch information
mattwthompson authored Dec 10, 2024
1 parent 6c9fb6d commit ec5ce32
Show file tree
Hide file tree
Showing 18 changed files with 37 additions and 3,049 deletions.
1 change: 0 additions & 1 deletion .gitattributes

This file was deleted.

3 changes: 2 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 2
fetch-depth: 0

- name: Set environment variables
run: |
Expand Down Expand Up @@ -133,6 +133,7 @@ jobs:
run: |
micromamba info
micromamba list
pip list
- name: Check links
if: ${{ matrix.rdkit == true && matrix.openeye == true }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/beta_rc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 2
fetch-depth: 0

- name: Install environment with ${{ env.JOBNAME }}
uses: mamba-org/setup-micromamba@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 2
fetch-depth: 0

- name: Set environment variables
run: |
Expand Down
16 changes: 10 additions & 6 deletions .readthedocs.yaml
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
# https://docs.readthedocs.io/en/stable/config-file/v2.html
version: 2
sphinx:
configuration: docs/conf.py
fail_on_warning: true

build:
os: ubuntu-20.04
tools:
python: "mambaforge-4.10"

python:
install:
- method: setuptools
path: .
- method: pip
path: .

conda:
environment: docs/environment.yml

sphinx:
configuration: docs/conf.py
fail_on_warning: true

formats:
- pdf
3 changes: 1 addition & 2 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
include LICENSE
include MANIFEST.in
include versioneer.py

graft openff
global-exclude *.py[cod] __pycache__ *.so
global-exclude *.py[cod] __pycache__ *.so
2 changes: 1 addition & 1 deletion devtools/conda-envs/openeye-examples.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
dependencies:
# Base depends
- python
- pydantic
- versioningit
- packaging
- numpy
- networkx
Expand Down
3 changes: 2 additions & 1 deletion devtools/conda-envs/openeye.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
dependencies:
# Base depends
- python
- pydantic
- versioningit
- packaging
- numpy
- networkx
Expand Down Expand Up @@ -34,6 +34,7 @@ dependencies:
- toml
- bson
- msgpack-python
- pydantic
- qcelemental
- qcportal >=0.50
- qcengine
Expand Down
2 changes: 1 addition & 1 deletion devtools/conda-envs/rdkit-examples.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
dependencies:
# Base depends
- python
- pydantic
- versioningit
- packaging
- numpy
- networkx
Expand Down
3 changes: 2 additions & 1 deletion devtools/conda-envs/rdkit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
dependencies:
# Base depends
- python
- pydantic
- versioningit
- packaging
- numpy
- networkx
Expand Down Expand Up @@ -35,6 +35,7 @@ dependencies:
- toml
- bson
- msgpack-python
- pydantic
- qcelemental
- qcportal >=0.50
- qcengine
Expand Down
3 changes: 2 additions & 1 deletion devtools/conda-envs/test_env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ channels:
dependencies:
# Base depends
- python
- versioningit
- packaging
- numpy
- networkx
Expand Down Expand Up @@ -40,6 +41,7 @@ dependencies:
- toml
- bson
- msgpack-python
- pydantic
- qcelemental
- qcportal >=0.50
- qcengine
Expand All @@ -50,7 +52,6 @@ dependencies:
- nomkl
- mypy
- typing_extensions
- pydantic
- pip:
- types-setuptools
- types-toml
Expand Down
2 changes: 1 addition & 1 deletion docs/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies:
- sphinx-notfound-page
- sphinx=6
# conda build dependencies
- python
- python <3.13
- setuptools
- numpy
- openmm
Expand Down
15 changes: 9 additions & 6 deletions docs/releasehistory.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,22 @@ Releases follow the `major.minor.micro` scheme recommended by [PEP440](https://w
### Behavior changes

### Bugfixes
- [PR #1971](https://github.com/openforcefield/openff-toolkit/pull/1971): Fixes bug where OpenEyeToolkitWrapper would write coordinate-less PDB atoms if insertion_code or chain_id was an empty string ([Issue #1967](https://github.com/openforcefield/openff-toolkit/issues/1967))

- [PR #1971](https://github.com/openforcefield/openff-toolkit/pull/1971): Fixes bug where OpenEyeToolkitWrapper would write coordinate-less PDB atoms if insertion_code or chain_id was an empty string ([Issue #1967](https://github.com/openforcefield/openff-toolkit/issues/1967))

### New features

### Improved documentation and warnings

### Tests updated

- [PR #1965](https://github.com/openforcefield/openff-toolkit/pull/1965): Fixes slight difference in GBSA energy reported in [Issue #1964](https://github.com/openforcefield/openff-toolkit/issues/1964) by forcing the use of the Reference platform in OpenMM for both calculations.
- [PR #1965](https://github.com/openforcefield/openff-toolkit/pull/1965): Disables testing of parmed-dependent notebook in `external` examples, since ParmEd 3 is no longer compatible with our upstreams and ParmEd 4 raises an error for our use cases.
- [PR #1965](https://github.com/openforcefield/openff-toolkit/pull/1965): Uses a different molecule in test_nagl's test_unsupported_molecule_bond to avoid having molecule handled successfully by nagl's new lookup table.
- [PR #1965](https://github.com/openforcefield/openff-toolkit/pull/1965): Fixes slight difference in GBSA energy reported in [Issue #1964](https://github.com/openforcefield/openff-toolkit/issues/1964) by forcing the use of the Reference platform in OpenMM for both calculations.
- [PR #1965](https://github.com/openforcefield/openff-toolkit/pull/1965): Disables testing of parmed-dependent notebook in `external` examples, since ParmEd 3 is no longer compatible with our upstreams and ParmEd 4 raises an error for our use cases.
- [PR #1965](https://github.com/openforcefield/openff-toolkit/pull/1965): Uses a different molecule in test_nagl's test_unsupported_molecule_bond to avoid having molecule handled successfully by nagl's new lookup table.

### Miscellaneous

- [PR #1970](https://github.com/openforcefield/openff-toolkit/pull/1970): Consolidates config files into `pyproject.toml`.
- [PR #1968](https://github.com/openforcefield/openff-toolkit/pull/1968): Switches version handling to `versioningit`.

## 0.16.6

Expand All @@ -49,7 +53,6 @@ Releases follow the `major.minor.micro` scheme recommended by [PEP440](https://w
### Tests updated
- [PR #1942](https://github.com/openforcefield/openff-toolkit/pull/1942): Update tests for newer versions of RDKit, while stepping around recent RDKit conda-forge packages that fail when run natively on osx-arm64.


## 0.16.5

### Improved documentation and warnings
Expand Down
5 changes: 2 additions & 3 deletions openff/toolkit/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@
"""

import importlib
from importlib.metadata import version
from typing import TYPE_CHECKING

from openff.toolkit._version import get_versions

if TYPE_CHECKING:
# These types are imported lazily at runtime, but we need to tell type
# checkers what they are
Expand All @@ -27,7 +26,7 @@
ToolkitRegistry,
)

__version__ = get_versions()["version"]
__version__ = version("openff.toolkit")

__all__ = [
"GLOBAL_TOOLKIT_REGISTRY",
Expand Down
Loading

0 comments on commit ec5ce32

Please sign in to comment.