-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenFF Lipid Optimization Benchmark Supplement v1.0 #399
base: master
Are you sure you want to change the base?
Conversation
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
0bed114
to
99cbb6d
Compare
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
Marking this ready for review now that #412 is in, and we don't need to worry about splitting it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor note about the threshold -- otherwise LGTM. Looking forward to see how the split workers go!
submissions/2024-10-30-OpenFF-Lipid-Optimization-Benchmark-Supplement-v1.0/opt.toml
Outdated
Show resolved
Hide resolved
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
LGTM thank you Brent! I'll let you merge so you can figure out compute tags? |
Ah oops -- probably from #412. Surprised it's not pulled in by qcportal! Edit: actually it's the backlog environment and script, I'll open a PR to only import on type checking |
This is the benchmarking counterpart to #394, constructed from full molecules in the LIPID MAPS database.
I think this is generally ready to go (besides updating the main README), but I'm leaving it as a draft because @j-wags and I discussed a bit about possibly partitioning datasets based on molecule size to make requesting compute resources of a certain size easier. We weren't sure exactly where to draw that cutoff, but this set ranges in size from 6 atoms to 106 atoms, so I thought it might be worth discussing.(Edit: the splitting stuff is resolved by the new tagging mechanism in #412, so this should be good to go).New Submission Checklist
README.md
describing the dataset see here for examplesdataset*.json
; may feature a compression extension, such as.bz2
README.md