add a map background #133
Merged
add a map background #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12rambau
requested review from
cdanielw,
dfguerrerom,
eriklindquist and
lpaolini
dfguerrerom
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SEPAL V1 evaluation some user were saying that the platform is great because everything live in the same place. Let's make the documentation feel more like home.
With this PR, the documentation will be displayed in the same theme as SEPAL matching it's coloring and presentation (map background). As we want to stay flexible it will remain possible to switch back to the light theme using the moon button (top-right corner).
here is a pre-build using it:
The map I use is coming from cartoDB so it's free to use (as long as we stay on the CC licensing).
If you think we could have accecibility issue I run a lightouse report on the page and the results are quite good :
https://sepal-doc--133.org.readthedocs.build/en/133/index.html
let me know what you think!
Fox #29