-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a fullscreen parameter to display bigger menu in map applications #756
Conversation
Codecov Report
@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 94.01% 93.57% -0.44%
==========================================
Files 42 42
Lines 4508 4283 -225
==========================================
- Hits 4238 4008 -230
- Misses 270 275 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The documentation bug is relative to this PR: sphinx-doc/sphinx#10691 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea, it looks great, I've tested it and works as expected.
- What do you think if we add a centered button at the bottom of the card saying "close"? As the card renders over all the window, the user could lose the sense of where it was opened (because it is not at the corner of the map btn as the others)... or perhaps a cross icon at the top right corner?
- As I understand the menu card, I think that the content will be used to display text, right? what about centering the title?
I was more picturing a dashboard tile when you don't need the map anymore, let me send you a mockup as an example
let me ask the question on UX stackexchange. I would like to avoid the big button but I'm not sure people will notice little "x" in the top header. there is still the "escape" otpion as well |
comming back from UX, they suggested to fix the state "active" of the menu btn while the window is opened so that you can recognize where you're coming from. The x was considered but seems weird if not set everywhere. I'll go with that, update the tests and merge it |
Fix #755
The idea is simle sometime I don't need the map anymore and I just want to display stuff to my users.
With this control option, I can create a control that fit nicely the frame of a map application (margin and icon width are absolute). It's only based on .css tricks so it cannot be coded outside of the lib.
let me know if you want to tune it. here are 2 examples, one in an app, one with a standalone fullscreen map: