Skip to content

Commit

Permalink
Bugfix - last commit hash written before build successful. (#6355)
Browse files Browse the repository at this point in the history
This isn't the cause of the current nightly build errors, but it hides the actual cause. 

Because lasthash.txt is written before the build is successful it means it's not trying to do the build each night even though the actual packages are older than the last commit.  

Moving it to the end of the script will mean that our log file will show the real error messages preventing the build.
  • Loading branch information
ofTheo authored and arturoc committed Aug 19, 2019
1 parent 14d0e0c commit 99e2741
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/dev/nightlybuilds.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ if [ "$currenthash" = "$lasthash" ]; then
exit 0
fi

echo $currenthash>lasthash.txt
./create_package.sh linux64 $lastversion master gcc4
./create_package.sh linux64 $lastversion master gcc5
./create_package.sh linux64 $lastversion master gcc6
Expand Down Expand Up @@ -108,6 +107,7 @@ echo

mail -s "Nightly builds $lastversion OK." $REPORT_MAIL <<EOF
Successfully created nightly builds for ${lastversion}
echo $currenthash>lasthash.txt
$(if [ -f /home/ofadmin/logs/nightlybuilds.log ]; then cat /home/ofadmin/logs/nightlybuilds.log; fi)
EOF
Expand Down

0 comments on commit 99e2741

Please sign in to comment.