Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_libs.sh doesn't properly download alternate versions #6623

Open
drfuzzyness opened this issue Oct 26, 2020 · 0 comments
Open

download_libs.sh doesn't properly download alternate versions #6623

drfuzzyness opened this issue Oct 26, 2020 · 0 comments
Assignees

Comments

@drfuzzyness
Copy link

drfuzzyness commented Oct 26, 2020

I believe I've found a bug in the download_libs.sh where if a VER is supplied (such as 0.10.1 or 0.11.0), the download fails. It looks like the script's logic doesn't match the URL structure of the CI filestore it downloads from (http://ci.openframeworks.cc/libs/).

An example URL is generated here:

PKGS="openFrameworksLibs_${VER}_${PLATFORM}${ARCH}.tar.bz2"

Which is then used here:

download(){
echo "Downloading $1"
wget ci.openframeworks.cc/libs/$1 $SILENT_ARGS
}

The logic works for a default VER of master, but doesn't work for named semantic versions (ex 0.10.1) as their URLs look like http://ci.openframeworks.cc/libs/0.10.1/openFrameworksLibs_master_linux64gcc6.tar.bz2.

A solution might catch a semver VER and direct to the correct file or add an additional variable for named branches.

I found then when attempting to implement a continuous integration build system where openFrameworks is tagged to a specific version.

Thanks!

drfuzzyness added a commit to drfuzzyness/openFrameworks that referenced this issue Oct 26, 2020
Allows downloading of semver versions of libs such as `0.10.1`
openframeworks#6623
@danoli3 danoli3 self-assigned this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants