fix shaders examples for Raspberry Pi #6223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avilleret can you change OF_TARGET_RASPBERRY_PI to OF_TARGET_OPENGLES The first is very specific to one platform but that code can be used in other opengl es bases platforms so it's better to use that macro instead |
|
thanks @arturoc for the review, it's done |
|
@arturoc shouldn't it be |
|
ugh yeah sorry i didn't realize either. do you want to send a new PR? |
|
could you do it ? |
gumilastik
pushed a commit
to gumilastik/openFrameworks
that referenced
this pull request
Feb 27, 2019
#changelog #opengles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR try to fix shader examples for Raspberry Pi
fix #5056