Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme ci status #6391

Merged
merged 9 commits into from
Oct 15, 2019
Merged

Readme ci status #6391

merged 9 commits into from
Oct 15, 2019

Conversation

roymacdonald
Copy link
Contributor

@roymacdonald roymacdonald commented Oct 12, 2019

I added to the readme CI status badges for each platform. I think this is super useful and handy.
@arturoc @bakercp @ofZach @ofTheo

(see it in action here https://github.com/roymacdonald/openFrameworks/tree/readmeCIStatus -- appveyor needs a page refresh for some reason)

@ofTheo
Copy link
Member

ofTheo commented Oct 12, 2019

This looks great to me! Nice to quickly see what is working/broken.

@bakercp
Copy link
Member

bakercp commented Oct 15, 2019

This seems good. Would be nice if we could get both master and stable branches listed.

@roymacdonald
Copy link
Contributor Author

roymacdonald commented Oct 15, 2019

@bakercp please correct me if wrong. The stable branch is the one with the build distributed at openframeworks.cc/download ?

I made what you suggested as a different branch, simply to check. If the rest agrees I can merge it into this PR
https://github.com/roymacdonald/openFrameworks/tree/readmeCIStatus2
cheers

@arturoc
Copy link
Member

arturoc commented Oct 15, 2019

yes that's it, stable should be the same as the current download, and yes just add those changes to this PR and i'll merge them

@roymacdonald
Copy link
Contributor Author

@arturoc Just added the stable and master status. ready for merging

Copy link
Member

@bakercp bakercp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend a small clarification here.

README.md Outdated Show resolved Hide resolved
of master and stable branches
@bakercp
Copy link
Member

bakercp commented Oct 15, 2019

Looks great.

@arturoc arturoc merged commit 34a9630 into openframeworks:master Oct 15, 2019
@roymacdonald roymacdonald deleted the readmeCIStatus branch October 15, 2019 18:19
@bakercp
Copy link
Member

bakercp commented Oct 15, 2019

@roymacdonald Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants