-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substitute defines DEG_TO_RAD / RAD_TO_DEG with ofDegToRad / ofRadToDeg #7413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artificiel
reviewed
Mar 22, 2023
dimitre
requested review from
artificiel and
ofTheo
and removed request for
artificiel
March 22, 2023 13:19
looks great @dimitre! |
ofTheo
reviewed
Mar 22, 2023
Hey! I think there are two fixes need at lines 511 and 512 of of3DGraphics. Pi is used in instead of two_pi
6783807#diff-d65e3c3d754334a7189b5c27b80d2f6c4760d9357b1c5b8639c99082ab1acfeeR511
The rest looks great!
|
ofTheo
reviewed
Mar 23, 2023
Amazing - thanks so much @dimitre! |
dimitre
added a commit
to dimitre/openFrameworks
that referenced
this pull request
Mar 26, 2023
…eg (openframeworks#7413) #changelog #math #internals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More
Substituting MIN / MAX to std::min std::max
FLT_EPSILON to std equivalent
pi, half_pi, two_pi by glm ones
now we can remove the unused constants later on a breaking release 0.12.0