Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute defines DEG_TO_RAD / RAD_TO_DEG with ofDegToRad / ofRadToDeg #7413

Merged
merged 17 commits into from
Mar 23, 2023

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Mar 22, 2023

More
Substituting MIN / MAX to std::min std::max
FLT_EPSILON to std equivalent
pi, half_pi, two_pi by glm ones

now we can remove the unused constants later on a breaking release 0.12.0

@dimitre dimitre marked this pull request as ready for review March 22, 2023 01:14
libs/openFrameworks/gl/ofLight.cpp Show resolved Hide resolved
libs/openFrameworks/math/ofMath.h Outdated Show resolved Hide resolved
@ofTheo
Copy link
Member

ofTheo commented Mar 22, 2023

looks great @dimitre!

@ofTheo
Copy link
Member

ofTheo commented Mar 23, 2023 via email

@dimitre dimitre merged commit b734917 into openframeworks:master Mar 23, 2023
@ofTheo
Copy link
Member

ofTheo commented Mar 23, 2023

Amazing - thanks so much @dimitre!
This has been on the list for ages 🎉

@dimitre dimitre deleted the deg branch March 23, 2023 17:42
dimitre added a commit to dimitre/openFrameworks that referenced this pull request Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants