✨(react) add TextArea component #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 56c8138 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
NathanVss
force-pushed
the
feat/textarea
branch
from
c85a983 to
fd6d395
Compare
jbpenrath
reviewed
Oct 23, 2023
Comment on lines
+6
to
+9
| "border-radius": "8px", | ||
| "border-radius--hover": "2px", | ||
| "border-radius--focus": "2px", | ||
| "border-width": "1px", |
There was a problem hiding this comment.
I realized we are defining those tokens for each inputs that seems weird. This is not in the scope of this PR, but I think there is something to improve here.
There was a problem hiding this comment.
Yes I agree, we have to keep in mind that we still want to guarantee the possibilty to customize them for each individual inputs, but in the mean time those are always the same .. 🤔
NathanVss
force-pushed
the
feat/textarea
branch
from
fd6d395 to
fbb3958
Compare
NathanVss
force-pushed
the
feat/textarea
branch
from
14c895f to
aca28b4
Compare
How could we ship a design system library without a textarea?
This is made to showcase the TextArea in real world use cases.
This typo was probably due to a bad copy pasta.
The font family of the design system was not applied to input value.
NathanVss
force-pushed
the
feat/textarea
branch
from
aca28b4 to
56c8138
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How could we ship a design system library without a textarea?