✨(website) filter contents by playlist #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/website/resource-filter-playlist
branch
3 times, most recently
from
064ac86
to
9a0eccd
Compare
AntoLC
force-pushed
the
feature/anthony/website/resource-filter-playlist
branch
from
9a0eccd
to
7358de7
Compare
kernicPanel
reviewed
Apr 12, 2023
Comment on lines
133
to
143
| pad={showFilter ? 'medium' : '0px'} | ||
| height={{ max: showFilter ? '300px' : '0px' }} | ||
| style={{ | ||
| transform: showFilter ? 'scaleX(1)' : 'scaleX(0.2)', | ||
| opacity: showFilter ? '1' : '0', | ||
| transition: 'all 0.3s ease-in-out', | ||
| boxShadow: 'inset rgba(2, 117, 180, 0.3) 1px 1px 6px 0px', |
There was a problem hiding this comment.
IMHO, I prefer something like this, only vertical animation and no boxshadow, WDYT ?
Suggested change
| pad={showFilter ? 'medium' : '0px'} | |
| height={{ max: showFilter ? '300px' : '0px' }} | |
| style={{ | |
| transform: showFilter ? 'scaleX(1)' : 'scaleX(0.2)', | |
| opacity: showFilter ? '1' : '0', | |
| transition: 'all 0.3s ease-in-out', | |
| boxShadow: 'inset rgba(2, 117, 180, 0.3) 1px 1px 6px 0px', | |
| pad="small" | |
| height={{ max: showFilter ? '300px' : '0px' }} | |
| style={{ | |
| transform: showFilter ? 'scaleY(1)' : 'scaleY(0)', | |
| transformOrigin: 'top', | |
| opacity: showFilter ? '1' : '0', | |
| transition: 'all 0.3s ease-in-out', | |
| boxShadow: 'none', |
filters.mp4
There was a problem hiding this comment.
Yes vertical anim is nice as well.
For the pad line 33, I kept the same pad of the other white block, if you don't switch it to 0, the dom keep the padding height when it is not displayed.
Personally I like the boxShadow inset, give a bit of relief and help to distinguish from the content, but it is probably subjective.
Let's see what Manu say, but I am totally open for changes.
There was a problem hiding this comment.
From the daily, we agreed on the vertical anim and kept the boxShadow.
lunika
approved these changes
Apr 24, 2023
lunika
reviewed
Apr 24, 2023
CHANGELOG.md
Outdated
| @@ -18,6 +18,7 @@ Versioning](https://semver.org/spec/v2.0.0.html). | |||
| - Add sentry | |||
| - Create a live from the website (#2134) | |||
| - Integrate webinar dashboard (#2135) | |||
| - filter contents by playlist (#2176) | |||
There was a problem hiding this comment.
Don't forget to move in the unreleased section this modification
Refactor the header of the Contents page to a dedicated component in order to stay DRY between contents.
- Refactorise the way to get the data - Better control of dropdown components
- Filter the contents by playlist. - Add button filter
The homepage lists ressources, it uses the same component as the resource page. Problem is, we don't want a filter on the homepage. This commit makes the filter optional to not show the filter on the homepage.
When a welcome message was too long, it breaked a bit the layout of the classroom. We now truncate the message to 1 line.
Show if a filtering is applied on the resource list. This is done by showing a badge with the amount of filter applied.
AntoLC
force-pushed
the
feature/anthony/website/resource-filter-playlist
branch
from
7358de7
to
399ba1a
Compare
lunika
added a commit
that referenced
this pull request
Apr 28, 2023
Added - Standalone website: - Filter contents by playlist (#2176) - Add playlist contents on playlist page (#2182) - Add a button to create a playlist from any resource creation form - Add a command to sync media channel states and video states - pages model api for standalone footer TOS or some legal notices Changed - Standalone website: - Improve architecture Contents feature (#2183) - Move edition icon on title input at the begining of the input - Increase description textarea min height - Marsha permission core split files Removed - start date under the title on the BBB dashboard Fixed - Standalone website: - Correctly display creation form when there is no playlist
lunika
added a commit
that referenced
this pull request
Apr 28, 2023
Added - Standalone website: - Filter contents by playlist (#2176) - Add playlist contents on playlist page (#2182) - Add a button to create a playlist from any resource creation form - Add a command to sync media channel states and video states - pages model api for standalone footer TOS or some legal notices Changed - Standalone website: - Improve architecture Contents feature (#2183) - Move edition icon on title input at the begining of the input - Increase description textarea min height - Marsha permission core split files Removed - start date under the title on the BBB dashboard Fixed - Standalone website: - Correctly display creation form when there is no playlist
lunika
added a commit
that referenced
this pull request
May 2, 2023
Added - Standalone website: - Filter contents by playlist (#2176) - Add playlist contents on playlist page (#2182) - Add a button to create a playlist from any resource creation form - Add a command to sync media channel states and video states - pages model api for standalone footer TOS or some legal notices Changed - Standalone website: - Improve architecture Contents feature (#2183) - Move edition icon on title input at the begining of the input - Increase description textarea min height - Marsha permission core split files Removed - start date under the title on the BBB dashboard Fixed - Standalone website: - Correctly display creation form when there is no playlist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Feature request: #2146
Add a filter on the content page, only playlist filter for the moment.
Proposal
Marsha.-filter.webm