⬆️(e2e) upgrade playwright docker image to v1.40.0#2433
Merged
Conversation
kernicPanel
approved these changes
Sep 25, 2023
Collaborator
Author
|
@kernicPanel I think we have to install python 3.11 in our local e2e image I think. I will do it in this PR |
lunika
force-pushed
the
playwright-upgrade
branch
from
e397693 to
0e02f18
Compare
kernicPanel
approved these changes
Sep 25, 2023
Member
kernicPanel
left a comment
kernicPanel
left a comment
There was a problem hiding this comment.
OK for me in local, but the webkit fail in CI is intriguing…
lunika
force-pushed
the
playwright-upgrade
branch
4 times, most recently
from
0a6d00e to
804a873
Compare
Collaborator
Author
|
We have to wait the 1.40 release to fix the libsoup bug microsoft/playwright#27313 (comment) |
lunika
force-pushed
the
playwright-upgrade
branch
from
804a873 to
795beac
Compare
lunika
changed the title
The docker image version of playwright does not match anymore the python playsright package. We have to upgrade it both in our image and in the CI.
we are using python 3.11 in marsha image. To be iso we must install install python 3.11 in the e2e image.
The new env file env.d/db must be used in the e2e service otherwise the e2e service is not able anymore to connect to the database.
lunika
force-pushed
the
playwright-upgrade
branch
from
795beac to
243005d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The docker image version of playwright does not match anymore the python playsright package. We have to upgrade it both in our image and in the CI.
Proposal