Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(front) display founders logo in the Footer #2627

Merged
merged 1 commit into from
Oct 7, 2024
Merged

✨(front) display founders logo in the Footer #2627

merged 1 commit into from
Oct 7, 2024

Conversation

lunika
Copy link
Member

@lunika lunika commented Sep 25, 2024

Purpose

We have to display founders logo in the Footer and a text explaining that the project has been financed by the recovery plan.

Screenshot 2024-10-04 at 10-45-56 Marsha

Screenshot 2024-10-04 at 10-46-22 Marsha

Proposal

  • display founders logo in the Footer

Copy link
Member

@kernicPanel kernicPanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also manage the mobile view.
Currently the logos are not visible.

@jbpenrath
Copy link
Member

We should also manage the mobile view. Currently the logos are not visible.

To ease the support of mobile, we could put that logos into the footer WDYT ? Next to "mentions légales" ?

We have to display founders logo in the Footer and a text explaining
that the project has been financed by the recovery plan.
@lunika lunika changed the title ✨(front) display founders logo on the login page ✨(front) display founders logo in the Footer Oct 4, 2024
@lunika
Copy link
Member Author

lunika commented Oct 4, 2024

@jbpenrath @kernicPanel I have changed where the logo are display to put them in the Footer as suggested by @jbpenrath

@lunika lunika merged commit 01ab44e into master Oct 7, 2024
32 of 33 checks passed
@lunika lunika deleted the login-page branch October 7, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants