Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌(front) pin videojs to version 7.11.4 #899

Merged
merged 1 commit into from
Mar 22, 2021
Merged

📌(front) pin videojs to version 7.11.4 #899

merged 1 commit into from
Mar 22, 2021

Conversation

lunika
Copy link
Member

@lunika lunika commented Mar 22, 2021

Purpose

To upgrade to videojs 7.11 we had to remove the yarn.lock file to
resolve videojs dependencies issue. Doing this, a more recent version of
@types/react-router is installed, LTIRoutes component must be adapt with
its new types.

Proposal

  • pin video.js to version 7.11.4

@lunika lunika requested a review from jbpenrath March 22, 2021 09:42
@lunika lunika self-assigned this Mar 22, 2021
Copy link
Member

@jbpenrath jbpenrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just fix types in LTIRoutes component?
Because in fact, react-router match.params as been improved. Previously it was defined so it was any and know it is [x:string]: string | undefined

src/frontend/package.json Show resolved Hide resolved
@lunika lunika changed the title 📌(front) pin veidojs to version 7.11.4 📌(front) pin videojs to version 7.11.4 Mar 22, 2021
@lunika lunika requested a review from jbpenrath March 22, 2021 13:15
Copy link
Member

@jbpenrath jbpenrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is not agree but ...
LGTM ! ✅

To upgrade to videojs 7.11 we had to remove the yarn.lock file to
resolve videojs dependencies issue. Doing this, a more recent version of
@types/react-router is installed, LTIRoutes component must be adapt with
its new types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants