Skip to content

Commit

Permalink
🐛(provisioning) fix unique count queries aggregation
Browse files Browse the repository at this point in the history
For unique (complete) views, aggregation was based on the actors.
However, it was incorrect as the metric is a unique count on them.
Furthermore, the number of views displayed was limited to 500.
To be correct, the aggregation needs to be based on the video ids.
  • Loading branch information
quitterie-lcs committed May 4, 2022
1 parent 806f0e0 commit 6ad76da
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/dashboards/teachers/course.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ dashboard.new(
bucketAggs=[
{
id: 'name',
field: common.fields.actor_account_name,
field: common.fields.video_id,
type: 'terms',
settings: {
order: 'desc',
Expand Down Expand Up @@ -340,7 +340,7 @@ dashboard.new(
bucketAggs=[
{
id: '5',
field: common.fields.actor_account_name,
field: common.fields.video_id,
type: 'terms',
settings: {
min_doc_count: '0',
Expand Down
4 changes: 2 additions & 2 deletions src/dashboards/teachers/details.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ dashboard.new(
bucketAggs=[
{
id: 'name',
field: common.fields.actor_account_name,
field: common.fields.video_id,
settings: {
order: 'desc',
orderBy: '_count',
Expand Down Expand Up @@ -148,7 +148,7 @@ dashboard.new(
bucketAggs=[
{
id: '5',
field: common.fields.actor_account_name,
field: common.fields.video_id,
settings: {
min_doc_count: '0',
size: '0',
Expand Down

0 comments on commit 6ad76da

Please sign in to comment.