Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(dashboard) add courses and statements dashboards #14

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

SergioSim
Copy link
Contributor

@SergioSim SergioSim commented Jun 29, 2021

Purpose

We want dedicated dashboards to display statistics about videos in a course.

Proposal

Add course and statements dashboards

@SergioSim SergioSim force-pushed the add-course-dashboard branch 3 times, most recently from b54bb5b to cca834a Compare June 30, 2021 07:23
@SergioSim SergioSim marked this pull request as ready for review June 30, 2021 07:25
Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative to start a lib 🥇

bin/jsonnet-lint Outdated Show resolved Hide resolved
src/dashboards/videos/common.libsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/common.libsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/common.libsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/common.libsonnet Outdated Show resolved Hide resolved
course_query: common.query.school_course_session,
completed: common.value.verb_id_completed,
},
refId: 'A',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do better than this default 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I think we have to choose a value between A-Z ? Found this old grafana post.

Copy link
Contributor

@jmaupetit jmaupetit Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it could be a unique identifier that could be personalized.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just take into account that queries named with "NA" won't be supported, plus the max of queries is about 26 (grafana/grafana#28104 (comment))
but if we personnalized them, we won't named them "NA" 😛

src/dashboards/videos/statements.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/statements.jsonnet Show resolved Hide resolved
src/dashboards/videos/statements.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/statements.jsonnet Show resolved Hide resolved
@quitterie-lcs quitterie-lcs mentioned this pull request Jul 1, 2021
src/dashboards/videos/course.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/course.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/course.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/course.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/course.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/statements.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/statements.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/statements.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/statements.jsonnet Outdated Show resolved Hide resolved
src/dashboards/videos/statements.jsonnet Outdated Show resolved Hide resolved
bin/jsonnet-lint Outdated Show resolved Hide resolved
Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done 💪

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We display course related statistics in a dedicated dashboards.
@SergioSim SergioSim merged commit c0fa2b9 into main Jul 16, 2021
@SergioSim SergioSim deleted the add-course-dashboard branch July 16, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants