Pull 62 #70
Merged
Pull 62 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
featureSRSconsistency - Test extending 13 which is currently only looking at table definitions, but if one inspects the standard, there are additional tests such as inconsistencies between srs_id that need to be examined. The feature portion of this test has been added to check for inconsistencies between the geopackage contents, the geopackage geometry columns, and the set of srs_id and feature tables. getFeaturesWithGeometryInfo - Iterator for processing feature geometry tests. This iterator performs the baseline query needed for all feature geometry tests, gathering the gpkg_geometry_columns values that will be checked for consistency against the geometry blob content in each feature. By processing these tests with the iterator, we can check for errors in each feature table and not just quit at the very first error found. featureGeometryEncodingTesting – Called by the iterator for each feature table, this test function performs all testing against the geometry blob for each row of the feature table. In order to maintain some processing performance, all of these tests have to be done here rather than re-process the blob for each test separately. The tests do attempt to re-use previously identified data. Each test performed within this group provides a detailed response if an issue is found. Reviewing the tests in here: 19 i Looks for the correct magic number 19 ii Looks for the correct version number 19 iii Verifies the binary type 19 iv Verifies the correct envelope flag values 33 Verifies the srs_id. This test also will check for byte swap errors within the srs_id, hence by putting the test before 19 v, it will catch potential byte swap errors that may affect retrieval of the envelope. 19 v If the geometry is empty but the envelope is not empty, triggers an error 20 Verifies the geometry type from within the WKB. This test also will check for possible byte swap errors within the WKB. 32 Checks if the WKB geometry type (subtype) is allowed based on the geometry type provided by gpkg_geometry_columns. 66 Partial – included only a check on the WKB item count value (when applicable) at this time. WKB processing is going to suck down a huge amount of processing time! 67 Check for gpkg_extensions for gpkg_geom_<feature> for the feature (when there are extensions). NSG 19B Ensure the geopackage extents from gpkg_geometry_columns contains the feature envelope. 78 Verify that the rtree trigger accurately contains the feature envelope when there are rtree extensions featureGeometryColumnsDataValuesTableNameNEW – Added because it does not appear that the existing tests for 23 and 26 are compliant with OGC 12-128r14. Also: Clean up of escaped single quotes in SQL statements.
This was referenced Jun 22, 2018
|
@jyutzler Yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a superset of #62
Actions: