Closes #18 #220
Merged
Closes #18 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstenger
requested changes
Jul 7, 2023
There was a problem hiding this comment.
When trying to build the feature branch with mvn clean install, I get following unit test failures:
Tests run: 15, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.585 sec <<< FAILURE! - in org.opengis.cite.ogcapifeatures10.util.JsonUtilsTest
testParseSpatialExtent_WithIntegerValues(org.opengis.cite.ogcapifeatures10.util.JsonUtilsTest) Time elapsed: 0.109 sec <<< ERROR!
java.lang.NullPointerException
at org.opengis.cite.ogcapifeatures10.util.JsonUtilsTest.testParseSpatialExtent_WithIntegerValues(JsonUtilsTest.java:152)
testParseSpatialExtent(org.opengis.cite.ogcapifeatures10.util.JsonUtilsTest) Time elapsed: 0.109 sec <<< ERROR!
java.lang.NullPointerException
at org.opengis.cite.ogcapifeatures10.util.JsonUtilsTest.testParseSpatialExtent(JsonUtilsTest.java:138)
Running org.opengis.cite.ogcapifeatures10.TestNGControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 sec - in org.opengis.cite.ogcapifeatures10.TestNGControllerTest
Running org.opengis.cite.ogcapifeatures10.conformance.ConformanceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec - in org.opengis.cite.ogcapifeatures10.conformance.ConformanceTest
Running org.opengis.cite.ogcapifeatures10.SuiteFixtureListenerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.187 sec - in org.opengis.cite.ogcapifeatures10.SuiteFixtureListenerTest
Results :
Tests in error:
JsonUtilsTest.testParseSpatialExtent:138 NullPointer
JsonUtilsTest.testParseSpatialExtent_WithIntegerValues:152 NullPointer
@bpross-52n Can you please take a look at those failures?
|
@dstenger I cannot reproduce these errors, I am afraid. I ran |
|
I pulled a new, clean checkout and now all unit tests are passing. I guess the previous failure was related to the fact that there was already an issue#18 branch before. |
|
As there is an unexpected failure with a reference implementation, I created a new issue in the deegree tracker: deegree/deegree-ogcapi#100 The Maven integration-tests currently fail. |
dstenger
approved these changes
Jul 13, 2023
|
Adjusted integration tests: 6adae39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18