Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #62 by specifying href format #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #62 by specifying href format #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions api/part1/standard/sections/clause_10_requirements_class_deployment_features.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,10 @@ NOTE: For deployments of models or processes, the location would usually not be
| `controlstreams` | - | The `Control Streams` that received commands issued during the `Deployment`. | A list of `ControlStream` resources (inline or by-reference). | Optional
|====

NOTE: The platform can be another `System` (e.g. a UAV or a station), but can also be any feature (e.g. a building or a tree).

When referencing a deployed local system resource via `deployedSystems`, the system SHALL be identified using a URN.
When referencing an external system resource the system SHALL be identified using a URL.
Copy link
Collaborator

@alexrobin alexrobin Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is somewhat encoding specific, I think it should be specified in the encoding sections instead:

In the requirements, we should refer to the System uniqueIdentifier instead of just saying "a URN".

Also, if you look at Deployment examples in GeoJSON and SensorML-JSON, you will see that both href and uid can be provided in the schema. So I think when you read it back, the uid property already contains the URN and the href can remain the URL. However, what I had in mind (sorry I did not express this clearly in the issue), is that on insertion, to simplify things for the server, we could mandate that the href is the UID instead of the URL when linking to a local system (whereas for remote systems, either the href URL only, or both URL and UID would be provided).

Does this make sense?


NOTE: The platform can be another `System` (e.g. a UAV or a station), but can also be any feature (e.g. a building or a tree).

=== Deployment Canonical URL

Expand Down