-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CQL JSON: "not equal" binary comparison not available #607
Comments
Suggested changes: // ...
"binaryComparisonPredicate": {
"oneOf": [
{ "$ref": "#/$defs/eqExpression" },
{ "$ref": "#/$defs/ltExpression" },
{ "$ref": "#/$defs/gtExpression" },
{ "$ref": "#/$defs/lteExpression" },
{ "$ref": "#/$defs/gteExpression" }
]
},
"eqExpression": {
"type": "object",
"required": ["eq"],
"properties": {
"eq": { "$ref": "#/$defs/scalarOperands" }
}
},
"neExpression": {
"type": "object",
"required": ["ne"],
"properties": {
"ne": { "$ref": "#/$defs/scalarOperands" }
}
},
"ltExpression": {
"type": "object",
"required": ["lt"],
"properties": {
"lt": { "$ref": "#/$defs/scalarOperands" }
}
},
"gtExpression": {
"type": "object",
"required": ["gt"],
"properties": {
"gt": { "$ref": "#/$defs/scalarOperands" }
}
},
"lteExpression": {
"type": "object",
"required": ["lte"],
"properties": {
"lte": { "$ref": "#/$defs/scalarOperands" }
}
},
"gteExpression": {
"type": "object",
"required": ["gte"],
"properties": {
"gte": { "$ref": "#/$defs/scalarOperands" }
}
},
// ...
|
Thanks! Yes, this is an oversight and will be corrected as proposed. |
Already identified as a deficiency in issue #578. |
Sorry, my bad. I did search for an existing issue, but that slipped through. |
@constantinius LOL! Sorry I was just trying to link the two issues so that we keep track of the fact that fixing this issue will also resolve part of #578. |
cportele
moved this to Done
in Features Part 3: Filtering / Common Query Language (CQL2)
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
not equal
predicate is available for CQL Text in the BNFbut not for CQL JSON encoding:
I understand that you could always do a
not
with aneq
inside, but this is needlessly complex and the same would be true for CQL Text. So thisproperty <> 123
could be written asNOT property = 123
My suggestion would be to add an
neExpression
(orneqExpression
) and add it as a possibility to thebinaryComparisonPredicate
.The text was updated successfully, but these errors were encountered: