Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background tracking support #5917

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Background tracking support #5917

wants to merge 23 commits into from
+825 −475

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Dec 27, 2024

This PR implements background tracking support in QField 🥳

Implementation notes:

  • Users must return to the QField app for the collected positions while QField was suspended to be saved into the vector layer tracks. This is a requirement to insure features will get proper expression context et al and avoid serious issues with vector layers co-existing in multiple processes.
  • The improvements fix an interesting out-of-sync situation where the position information was not necessarily matching the projected position (which is used to add vertices to the track feature).

Plenty of code refactoring has happened, hope it doesn't make it too much harder to review this.

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Dec 27, 2024 •
edited
Loading

🎉 Ta-daaa, freshly created APKs are available for 7d3df79: arm64-android

Other architectures

@nirvn nirvn force-pushed the tracking_background branch from e18ee86 to 838cf8f Compare December 27, 2024 09:37
nirvn added 18 commits December 28, 2024 10:12
@nirvn
Implement background positioning collection
50d3e04
@nirvn
Add an invokable function into the coordinate transformer to allow no…
4e4f0ac 
…n-signal-driven transformations
@nirvn
Fix missing vertical grid changed signal
5817668
@nirvn
Avoid signals when serving projected position, saves a few cycles
faee98b
@nirvn
Allow for ongoing tracking sessions to save collected positions when …
1aae3ee 
…leaving background mode
@nirvn
Support background tracking
e9f2c36
@nirvn
Optimize tracker replay for line and polygon geometries
0886933
@nirvn
Major improvement in the way we handle tracker properties
affe722
@nirvn
Fix starting new track takes on the last track's vertex within a sing…
7d768b8 
…le session
@nirvn
Fix cppcheck
95fce9f
@nirvn
Add missing documentation, improve background mode documentation
1627950
@nirvn
Rework tracker time constraint to rely on position information dateti…
872eb40 
…me information
@nirvn
Address const review
7c19385
@nirvn
TIL: Truncate doesn't truncate if nothing is written
b200d95
@nirvn
Implement a feature model batch mode to speed up tracking replay
5a1f924
@nirvn
Freeze map canvas when replaying
c5bf0bf
@nirvn
Add an action in the tracker badge toaster message to stop ongoing tr…
a61ec90 
…acking
@nirvn
Remove toaster that interferes with tracking due to icon name change
5d5827e
@nirvn nirvn force-pushed the tracking_background branch from 2dc78ad to 5d5827e Compare December 28, 2024 04:34
github-actions[bot]
github-actions bot reviewed Dec 28, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/featuremodel.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@m-kuhn m-kuhn m-kuhn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ENHANCEMENT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirvn @qfield-fairy @m-kuhn