Fix failing tests introduced with #202 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suricactus
force-pushed
the
revert_202
branch
6 times, most recently
from
426d000 to
d3b6f62
Compare
m-kuhn
reviewed
Dec 28, 2021
suricactus
force-pushed
the
revert_202
branch
from
ac011fe to
ba63a92
Compare
…e ids the worker wrapper caches outdated ContentType ids during tests since it runs in a separate container than the tests, which then the tests.
suricactus
changed the title
m-kuhn
reviewed
Jan 3, 2022
| @@ -41,6 +43,11 @@ def handle(self, *args, **options): | |||
|
|
|||
| while killer.alive: | |||
| with use_test_db_if_exists(): | |||
| # the worker wrapper caches outdated ContentType ids during tests since it runs in a separate | |||
| # container than the tests, which then the tests. | |||
There was a problem hiding this comment.
This sentence sounds like it has grammar issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes failing false alarm with breaking tests due to cached content type ids.
The worker wrapper caches outdated ContentType ids during tests since it runs in a separate container than the tests, which then the tests.